I might be "stuck in the old ways" but one of the gold standards to me is the classic Girl/Chocolate vids. Goldfish, Paco, Mouse. At least in terms of structure. Nobody has pulled off skits as well as they have.
More recently, videos that still have "parts" but it's looser, with b-roll type Segways that tie the parts together, kinda like an endless music mix with no real fade-to-blacks. Always enjoy when a song kicks in and I'm not expecting it. Original GX1000 video is a prime example.
As fas as "what makes a GOOD skate video" Capturing the fun, spontaneous, social aspects that occur naturally is more important than the level skateboarding. Easier said than done, obviously. Unless you're really there rolling all the time, it's hard to document.